Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export API to set RefTime of Updater #641

Merged
merged 5 commits into from
Jun 18, 2024
Merged

export API to set RefTime of Updater #641

merged 5 commits into from
Jun 18, 2024

Conversation

AdamKorcz
Copy link
Contributor

This PR exports an API to set the RefTime of the trusted metadata of an Updater. This is useful for testing time-related cases in the client outside of go-tufs own repository.

@AdamKorcz AdamKorcz requested a review from a team as a code owner June 18, 2024 12:24
AdamKorcz and others added 2 commits June 18, 2024 13:33
@AdamKorcz @kommendorkapten
Update metadata/updater/updater.go
a2d58b6 
Co-authored-by: Fredrik Skogman <[email protected]>
Signed-off-by: AdamKorcz <[email protected]>
@AdamKorcz
update name in test
de4dcfc 
Signed-off-by: Adam Korczynski <[email protected]>
@kommendorkapten
Copy link
Member

Thanks for the contribution @AdamKorcz, would you mind also adding a comment describing this, why it may be useful and any consequences of using this in a real life application?

@AdamKorcz
add comment to UnsafeSetRefTime
faf9792 
Signed-off-by: Adam Korczynski <[email protected]>
@AdamKorcz
Copy link
Contributor Author

Thanks for the contribution @AdamKorcz, would you mind also adding a comment describing this, why it may be useful and any consequences of using this in a real life application?

faf9792 - LMK if it needs more context. I have kept it short to align the description with other methods in the file.

@AdamKorcz @kommendorkapten
Update metadata/updater/updater.go
ee97dd4 
Co-authored-by: Fredrik Skogman <[email protected]>
Signed-off-by: AdamKorcz <[email protected]>
kommendorkapten
kommendorkapten approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@kommendorkapten kommendorkapten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kommendorkapten
Copy link
Member

@rdimitrov @trishankatdatadog any thoughts?

rdimitrov
rdimitrov approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@rdimitrov rdimitrov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdimitrov @trishankatdatadog any thoughts?

I think it makes sense 👍 I don't think it's worth it that much but I was going to suggest that we can make the RefTime field private and add set/get methods so setting it is even more explicit.

Thanks for these changes, @AdamKorcz 🙌

@kommendorkapten
Copy link
Member

I think it's fine w/out get/set? The other fields are lacking this, and I think it's clear with the current design?

@kommendorkapten kommendorkapten merged commit f1d8916 into theupdateframework:master Jun 18, 2024
23 checks passed
AdamKorcz added a commit to AdamKorcz/tuf-conformance that referenced this pull request Jun 18, 2024
@AdamKorcz
make test work for go-tuf
a3e3a4a 
enabled by theupdateframework/go-tuf#641

Signed-off-by: Adam Korczynski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdimitrov rdimitrov rdimitrov approved these changes

@kommendorkapten kommendorkapten kommendorkapten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdamKorcz @kommendorkapten @rdimitrov